On 06.06.25 10:26, Oscar Salvador wrote:
On Fri, Jun 06, 2025 at 10:23:11AM +0200, David Hildenbrand wrote:
See my reply to Dan.
Yet another boolean, yuck. Passing the folio and the pfn, yuck.
(I have a strong opinion here ;) )
ok, I see it was already considered. No more questions then ;-)
Yeah, the first version I had did exactly that (second boolean), and I
concluded that we are simply not "inserting PFNs".
Especially the second patch is much clearer on the pud_none() handling
(similar to insert_page_into_pte_locked() where we only have exactly one
such check)
I'll have some follow-up patches planned that will add more pfn-specific
and folio-specific sanity checks.
--
Cheers,
David / dhildenb