Small followup review, sorry for the noise.

On 2025-06-09 16:08:56+0100, Mark Brown wrote:
<snip>

> +#ifndef sys_vfork

This ifndef is not necessary here.
No architecture has a special version.

> +static __attribute__((unused))
> +pid_t sys_vfork(void)
> +{
> +#ifdef __NR_vfork

For consistency:
#if defined(__NR_vfork)

> +     return my_syscall0(__NR_vfork);
> +#elif defined(__NR_clone3)
> +     /*
> +      * clone() could be used but has different argument orders per
> +      * architecture.
> +      */
> +     struct clone_args args = {
> +             .flags          = CLONE_VM | CLONE_VFORK,
> +             .exit_signal    = SIGCHLD,
> +     };
> +
> +     return my_syscall2(__NR_clone3, &args, sizeof(args));
> +#else
> +     return __nolibc_enosys(__func__);
> +#endif
> +}
> +#endif

Reply via email to