> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf
> Of Stanislav Fomichev
> Sent: Tuesday, June 10, 2025 7:15 PM
> To: net...@vger.kernel.org
> Cc: da...@davemloft.net; eduma...@google.com; k...@kernel.org;
> pab...@redhat.com; skall...@marvell.com; mani...@marvell.com;
> andrew+net...@lunn.ch; michael.c...@broadcom.com;
> pavan.che...@broadcom.com; ajit.khapa...@broadcom.com;
> sriharsha.basavapa...@broadcom.com; somnath.ko...@broadcom.com;
> Nguyen, Anthony L <anthony.l.ngu...@intel.com>; Kitszel, Przemyslaw
> <przemyslaw.kits...@intel.com>; tar...@nvidia.com; sae...@nvidia.com;
> louis.pe...@corigine.com; shsha...@marvell.com; GR-Linux-NIC-
> d...@marvell.com; ecree.xil...@gmail.com; ho...@kernel.org;
> dsah...@kernel.org; sh...@kernel.org; ruanjin...@huawei.com;
> mh...@redhat.com; stfomic...@gmail.com; linux-kernel@vger.kernel.org;
> intel-wired-...@lists.osuosl.org; linux-r...@vger.kernel.org; oss-
> driv...@corigine.com; linux-net-driv...@amd.com; linux-
> kselft...@vger.kernel.org; l...@kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next v3 2/4] net: remove
> redundant ASSERT_RTNL() in queue setup functions
> 
> The existing netdev_ops_assert_locked() already asserts that either
> the RTNL lock or the per-device lock is held, making the explicit
> ASSERT_RTNL() redundant.
> 
> Cc: Michael Chan <michael.c...@broadcom.com>
> Signed-off-by: Stanislav Fomichev <stfomic...@gmail.com>
Reviewed-by: Aleksandr Loktionov <aleksandr.loktio...@intel.com>

> ---
>  net/core/dev.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/net/core/dev.c b/net/core/dev.c index
> be97c440ecd5..72997636b8ec 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -3179,7 +3179,6 @@ int netif_set_real_num_tx_queues(struct
> net_device *dev, unsigned int txq)
> 
>       if (dev->reg_state == NETREG_REGISTERED ||
>           dev->reg_state == NETREG_UNREGISTERING) {
> -             ASSERT_RTNL();
>               netdev_ops_assert_locked(dev);
> 
>               rc = netdev_queue_update_kobjects(dev, dev-
> >real_num_tx_queues, @@ -3229,7 +3228,6 @@ int
> netif_set_real_num_rx_queues(struct net_device *dev, unsigned int rxq)
>               return -EINVAL;
> 
>       if (dev->reg_state == NETREG_REGISTERED) {
> -             ASSERT_RTNL();
>               netdev_ops_assert_locked(dev);
> 
>               rc = net_rx_queue_update_kobjects(dev, dev-
> >real_num_rx_queues,
> --
> 2.49.0


Reply via email to