On 6/13/25 12:37 AM, André Apitzsch via B4 Relay wrote:
> From: André Apitzsch <[email protected]>
> 
> This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360) released
> in 2016.
> 
> Add a device tree with initial support for:
> 
> - GPIO keys
> - NFC
> - SDHCI
> - Status LED
> - Touchscreen
> 
> Signed-off-by: André Apitzsch <[email protected]>
> ---

[...]

> +             /delete-node/ tz-apps@8dd00000;

please remove nodes through a &label reference only 

in this specific case, the address matches, so you may want
to simply override reg with the bigger size instead

[...]

> +
> +             rmi4-f01@1 {
> +                     reg = <0x1>;
> +                     syna,nosleep-mode = <1>; /* Allow sleeping */
> +             };
> +
> +             rmi4-f12@12 {
> +                     reg = <0x12>;
> +                     syna,sensor-type = <1>; /* Touchscreen */

Please remove these commends

[...]

> +             };
> +     };
> +};
> +
> +&blsp2_uart2 {
> +     status = "okay";
> +};
> +
> +&gcc {
> +     vdd_gfx-supply = <&pm8004_s5>;
> +};
> +
> +&pm8004_spmi_regulators {
> +     vdd_s2-supply = <&vph_pwr>;
> +     vdd_s5-supply = <&vph_pwr>;
> +
> +     /* Cluster 1 supply */
> +     pm8004_s2: s2 {
> +             /* regulator-min-microvolt = <500000>; */
> +             /* Set .95V to prevent unstabilities until CPR for this SoC is 
> done */

That may take a while.. ;)

[...]

> +
> +     sdc2_default: sdc2-default-state {
> +             clk-pins {
> +                     pins = "sdc2_clk";
> +                     bias-disable;
> +                     drive-strength = <16>;
> +             };
> +             cmd-pins {
> +                     pins = "sdc2_cmd";
> +                     bias-pull-up;
> +                     drive-strength = <10>;
> +             };
> +             data-pins {
> +                     pins = "sdc2_data";
> +                     bias-pull-up;
> +                     drive-strength = <10>;
> +             };
> +     };
> +
> +     sdc2_sleep: sdc2-sleep-state {
> +             clk-pins {
> +                     pins = "sdc2_clk";
> +                     bias-disable;
> +                     drive-strength = <2>;
> +             };
> +             cmd-pins {
> +                     pins = "sdc2_cmd";
> +                     bias-pull-up;
> +                     drive-strength = <2>;
> +             };
> +             data-pins {
> +                     pins = "sdc2_data";
> +                     bias-pull-up;
> +                     drive-strength = <2>;
> +             };
> +     };

Please move these definitions into msm8976.dtsi

Konrad

Reply via email to