On 24.06.25 03:16, Alistair Popple wrote:
On Tue, Jun 17, 2025 at 05:43:38PM +0200, David Hildenbrand wrote:
Let's convert to vmf_insert_folio_pmd().
In the unlikely case there is already something mapped, we'll now still
call trace_dax_pmd_load_hole() and return VM_FAULT_NOPAGE.
That should probably be fine, no need to add special cases for that.
I'm not sure about that. Consider dax_iomap_pmd_fault() -> dax_fault_iter() ->
dax_pmd_load_hole(). It calls split_huge_pmd() in response to VM_FAULT_FALLBACK
which will no longer happen, what makes that ok?
My reasoning was that this is the exact same behavior other
vmf_insert_folio_pmd() users here would result in.
But let me dig into the details.
--
Cheers,
David / dhildenb
