Resolve minor resource leaks reported by cppcheck in napi_id_helper.c

cppcheck output before this patch:
tools/testing/selftests/drivers/net/napi_id_helper.c:37:3: error: Resource 
leak: server [resourceLeak]
tools/testing/selftests/drivers/net/napi_id_helper.c:46:3: error: Resource 
leak: server [resourceLeak]
tools/testing/selftests/drivers/net/napi_id_helper.c:51:3: error: Resource 
leak: server [resourceLeak]
tools/testing/selftests/drivers/net/napi_id_helper.c:59:3: error: Resource 
leak: server [resourceLeak]
tools/testing/selftests/drivers/net/napi_id_helper.c:67:3: error: Resource 
leak: server [resourceLeak]
tools/testing/selftests/drivers/net/napi_id_helper.c:76:3: error: Resource 
leak: server [resourceLeak]

cppcheck output after this patch:
No resource leaks found

Signed-off-by: Malaya Kumar Rout <malayarou...@gmail.com>
---
 tools/testing/selftests/drivers/net/napi_id_helper.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tools/testing/selftests/drivers/net/napi_id_helper.c 
b/tools/testing/selftests/drivers/net/napi_id_helper.c
index eecd610c2109..1441b8d49b91 100644
--- a/tools/testing/selftests/drivers/net/napi_id_helper.c
+++ b/tools/testing/selftests/drivers/net/napi_id_helper.c
@@ -34,6 +34,7 @@ int main(int argc, char *argv[])
 
        if (setsockopt(server, SOL_SOCKET, SO_REUSEADDR, &opt, sizeof(opt))) {
                perror("setsockopt");
+               close(server);
                return 1;
        }
 
@@ -43,11 +44,13 @@ int main(int argc, char *argv[])
 
        if (bind(server, (struct sockaddr *)&address, sizeof(address)) < 0) {
                perror("bind failed");
+               close(server);
                return 1;
        }
 
        if (listen(server, 1) < 0) {
                perror("listen");
+               close(server);
                return 1;
        }
 
@@ -56,6 +59,7 @@ int main(int argc, char *argv[])
        client = accept(server, NULL, 0);
        if (client < 0) {
                perror("accept");
+               close(server);
                return 1;
        }
 
@@ -64,6 +68,7 @@ int main(int argc, char *argv[])
                         &optlen);
        if (ret != 0) {
                perror("getsockopt");
+               close(server);
                return 1;
        }
 
@@ -73,6 +78,7 @@ int main(int argc, char *argv[])
 
        if (napi_id == 0) {
                fprintf(stderr, "napi ID is 0\n");
+               close(server);
                return 1;
        }
 
-- 
2.43.0


Reply via email to