On Thu, Jun 26, 2025 at 12:06 PM Onur Özkan <w...@onurozkan.dev> wrote:
>
> -        #[expect(clippy::unnecessary_cast)]

We should avoid converting them into `expect` in the previous patch,
because then it would break the build between the commits (it is not
too critical if it is a Clippy one, but we still aim to keep builds
Clippy clean).

In addition, the reasoning for each of these not being needed may not
be immediately obvious (unlike other lint patches that follow all a
pattern). So it would be best to split the patches into cases to
explain each. For instance, this one is because with the new custom
FFI mappings `c_long` is always `isize` now, which is always different
from `c_int` (`i32`).

By the way, please Cc the rust-for-linux list too.

Thanks!

Cheers,
Miguel

Reply via email to