On Fri, 4 Jul 2025 14:20:19 +0100 Simon Horman <[email protected]> wrote:
> On Wed, Jul 02, 2025 at 10:28:05AM +0200, Maxime Chevallier wrote: > > Now that netdevsim supports PHY device simulation, we can start writing > > some tests to cover a little bit all PHY-related ethtool commands. > > > > So far we only test the basic use of "ethtool --show-phys", with : > > - A simple command to get a PHY we just added > > - A DUMP command listing PHYs on multiple netdevsim instances > > - A Filtered DUMP command listing all PHYs on a netdevsim > > > > Introduce some helpers to create netdevsim PHYs, and a new test file. > > > > Signed-off-by: Maxime Chevallier <[email protected]> > > Hi Maxime, > > We have recently started running shellcheck as part of our CI (NIPA). > Could you do so for the scripts added and modified by this patch? Sure thing, I'll do that :) > > > --- > > .../selftests/drivers/net/netdevsim/config | 1 + > > .../drivers/net/netdevsim/ethtool-common.sh | 15 +++++ > > .../drivers/net/netdevsim/ethtool-phy.sh | 64 +++++++++++++++++++ > > Should ethtool-phy.sh be added to TEST_PROGS the Makefile in > the same directory? Ah yes I forgot that. So any file in that TEST_PROGS list will end-up being run in NAPI tests ? Maxime
