"Miguel Ojeda" <[email protected]> writes: > On Mon, Jul 7, 2025 at 3:31 PM Andreas Hindborg <[email protected]> wrote: >> >> Based on code by Adam Bratschi-Kaye lifted from the original `rust` branch >> [1]. > > I would suggest adding this sort of note to the commit messages, > especially since the commits have no Co-developed-by/Link tags > otherwise. > > From our discussion in Zulip: the code itself is older than that the > merge above. I think you wanted an example sentence for this -- > something simple could be e.g. > > Based on the original module parameter support by Miguel [1], > later extended and generalized by Adam for more types [2][3]. > Originally tracked at [4]. > > Link: https://github.com/Rust-for-Linux/linux/pull/7 [1] > Link: https://github.com/Rust-for-Linux/linux/pull/82 [2] > Link: https://github.com/Rust-for-Linux/linux/pull/87 [3] > Link: https://github.com/Rust-for-Linux/linux/issues/11 [4] > > By the way, I guess you should inherit that issue in the last link :) > It had some details about things we may or may not want to support > etc. that I looked up back then. If you prefer that we close it or > that we create sub-issues, that is fine -- up to you! > > Finally, if you end up adding strings, please link to Adam's > https://github.com/Rust-for-Linux/linux/pull/110.
Thanks, I'll add this! Best regards, Andreas Hindborg
