> -----Original Message----- > From: Hansen, Dave <[email protected]> > Sent: Monday, August 4, 2025 5:20 PM > To: Reshetova, Elena <[email protected]> > Cc: [email protected]; [email protected]; Huang, Kai > <[email protected]>; [email protected]; [email protected]; linux- > [email protected]; [email protected]; Mallick, Asit K > <[email protected]>; Scarlata, Vincent R > <[email protected]>; > Cai, Chong <[email protected]>; Aktas, Erdem <[email protected]>; > Annapurve, Vishal <[email protected]>; Bondarevska, Nataliia > <[email protected]>; Raynor, Scott <[email protected]> > Subject: Re: [PATCH v10 4/6] x86/sgx: Define error codes for use by > ENCLS[EUPDATESVN] > > On 8/4/25 00:21, Reshetova, Elena wrote: > ... > >>> + EUPDATESVN = 0x18, > >>> }; > >> > >> This update is not consistent with the changelog nor the patch subject. > > > > I can remove the alignment fix. > > It's not the alignment. > > It's the definition of EUPDATESVN that goes completely unmentioned.
Yes, good catch, this should be moved to the next patch indeed. > > ... > >> Ideally, we find a way to relay this in a very succinct way. > > > > Could you please elaborate what you mean by this? > > Changing the description? The name or? > > Relaying it in the comment next to the definition would be best. Sure, will try to extend the current description to convey it better. Best Regards, Elena.
