On Tue, 2025-08-19 at 09:28 +0200, David Hildenbrand wrote:
> On 19.08.25 09:25, David Hildenbrand wrote:
> > On 19.08.25 06:12, Aboorva Devarajan wrote:
> > > Removed an extra space in split_huge_page_test that was introduced
> > > by commit 4b76e221794b ("mm/selftests: fix split_huge_page_test
> > > failure on systems with 64KB page size").
> > >
> > > Signed-off-by: Aboorva Devarajan <[email protected]>
> > > ---
> > > tools/testing/selftests/mm/split_huge_page_test.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tools/testing/selftests/mm/split_huge_page_test.c
> > > b/tools/testing/selftests/mm/split_huge_page_test.c
> > > index 54e86f00aabc..faf7e1f88743 100644
> > > --- a/tools/testing/selftests/mm/split_huge_page_test.c
> > > +++ b/tools/testing/selftests/mm/split_huge_page_test.c
> > > @@ -544,7 +544,7 @@ int main(int argc, char **argv)
> > > ksft_exit_fail_msg("Reading PMD pagesize failed\n");
> > >
> > > nr_pages = pmd_pagesize / pagesize;
> > > - max_order = sz2ord(pmd_pagesize, pagesize);
> > > + max_order = sz2ord(pmd_pagesize, pagesize);
> > > tests = 2 + (max_order - 1) + (2 * max_order) + (max_order - 1)
> > > * 4 + 2;
> > > ksft_set_plan(tests);
> > >
> >
> > Please just comment next time one the respective patch as review comment.
> >
>
> To clarify what I mean is something like this:
>
> https://lkml.kernel.org/r/[email protected]
>
> Gives more context when the subject directly highlights to which patch
> you are replying.
Hi David,
Thanks for pointing this out. I’ll make sure to follow this.
Regards,
Aboorva
