On 19/09/25 04:10PM, Dave Jiang wrote:
On 9/17/25 6:40 AM, Neeraj Kumar wrote:
Prior to LSA 2.1 version, LSA contain only namespace labels. LSA 2.1
introduced in CXL 2.0 Spec, which contain region label along with
namespace label.
NDD_LABELING flag is used for namespace. Introduced NDD_REGION_LABELING
flag for region label. Based on these flags nvdimm driver performs
operation on namespace label or region label.
NDD_REGION_LABELING will be utilized by cxl driver to enable LSA 2.1
region label support
Accordingly updated label index version
Signed-off-by: Neeraj Kumar <[email protected]>
With the change noted below,
Reviewed-by: Dave Jiang <[email protected]>
<Snip>
/*
* EACCES failures reading the namespace label-area-properties
diff --git a/drivers/nvdimm/dimm_devs.c b/drivers/nvdimm/dimm_devs.c
index 21498d461fde..918c3db93195 100644
--- a/drivers/nvdimm/dimm_devs.c
+++ b/drivers/nvdimm/dimm_devs.c
@@ -18,6 +18,13 @@
static DEFINE_IDA(dimm_ida);
+bool nvdimm_check_region_label_format(struct device *dev)
Should be called nvdimm_region_label_supported() since a bool return is
expected instead of resolving the checking in the function.
DJ
Thanks Jonathan and Dave for RB tag. Sure, I will rename it accordingly
Regards,
Neeraj
