On Sun, Feb 03, 2008 at 10:54:45AM +0100, Frank Seidel wrote: > On Sunday 03 February 2008 04:04, Rabin Vincent wrote: > > This check is not required because the condition is always true. > > ... > > - if (niceval > retval) > > - retval = niceval; > > + retval = 20 - task_nice(p); > > Thats surely correct, but on the other hand currently those > case blocks are quite independet of their possition/could easily > be rearranged now .. or think of another case is put ahead. > Then this could mess up things.
Do you mean the PRIO_* cases in the switch? They're still independent of position after the patch because they don't fall through. > Thanks, > Frank Rabin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
