On Sun, Feb 03, 2008 at 08:00:47PM +0000, Adrian McMenamin wrote: > From: Adrian McMenamin > This is useless if you are submitting the patch, especially if you're missing a mail address.
> This patch fixes the regression noted here: > http://lkml.org/lkml/2008/1/26/189 as well as whitespace issues in the > previous commit of this driver and the memory leaks noted here: > http://lkml.org/lkml/2008/2/2/143 (as well as one or two other minor > cleanups). > The subject notes 3 specific things that are being addressed, but you've rolled this all in to one patch which makes it utterly impossible to figure out what you're actually fixing. At the very least, split this in to 3 different patches, each dealing with one of the things noted in the subject. The fact that regressions is plural also suggests you may want to split this down in to smaller patches that deal with specific regressions if they are not directly related. > Signed off by: Adrian McMenamin <[EMAIL PROTECTED]> > Do not invent new sign-off tags, see Documentation/SubmittingPatches. Scripts do end up having to parse this stuff. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
