On Mon, 2008-02-04 at 14:04 +0100, Jan-Bernd Themann wrote: > Add memory remove hotplug support > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > > --- > Comment: This patch depends on the following patch that > exports the symbols > register_memory_notifier() > unregister_memory_notifier() > > http://lkml.org/lkml/2008/2/1/293 > > > drivers/net/ehea/ehea_main.c | 25 +++++++++++++++++++++++++ > 1 files changed, 25 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c > index 21af674..b75afcc 100644 > --- a/drivers/net/ehea/ehea_main.c > +++ b/drivers/net/ehea/ehea_main.c
> @@ -3559,6 +3578,10 @@ int __init ehea_module_init(void)
> if (ret)
> ehea_info("failed registering reboot notifier");
>
> + ret = register_memory_notifier(&ehea_mem_nb);
> + if (ret)
> + ehea_info("failed registering memory remove notifier");
>
> ret = crash_shutdown_register(&ehea_crash_handler);
> if (ret)
> ehea_info("failed registering crash handler");
You don't do anything except print a message if the registration fails.
What happens when someone tries to remove memory but the memory notifier
wasn't registered properly? Bang?
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
