On 12/2/25 5:26 PM, Alexandru Gagniuc wrote:
> The wcss_q6_bcr_reset used on QCS404, and wcss_q6_reset used on IPQ
> are the same. "BCR reset" is redundant, and likely a mistake. Use the
> documented "wcss_q6_reset" instead. Drop ".wcss_q6_reset_required"
> from the descriptor, since all targets now need it.
>
> Fixes: 0af65b9b915e ("remoteproc: qcom: wcss: Add non pas wcss Q6 support for
> QCS404")
>
> Signed-off-by: Alexandru Gagniuc <[email protected]>
> ---
[...]
> - wcss->wcss_q6_bcr_reset = devm_reset_control_get_exclusive(dev,
> "wcss_q6_bcr_reset");
> - if (IS_ERR(wcss->wcss_q6_bcr_reset)) {
> - dev_err(wcss->dev, "unable to acquire wcss_q6_bcr_reset\n");
> - return PTR_ERR(wcss->wcss_q6_bcr_reset);
> + wcss->wcss_q6_reset = devm_reset_control_get_exclusive(dev,
> "wcss_q6_reset");
> + if (IS_ERR(wcss->wcss_q6_reset)) {
This changes the bindings expectations
*however*
it actually fixes the driver to consume the intended ones (qcom,q6v5.txt)
(not even yaml!!!) which houses the description of the qcs404 wcss lists
wcss_q6_reset and *not* "wcss_q6_bcr_reset"
Please add a paragraph mentioning this in the commit message and add my
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
