On Wed, Dec 24, 2025 at 09:37:14AM +0800, Xuan Zhuo wrote: > > Hi Jason, > > I'm wondering why we even need this refill work. Why not simply let NAPI retry > the refill on its next run if the refill fails? That would seem much simpler. > This refill work complicates maintenance and often introduces a lot of > concurrency issues and races. > > Thanks.
refill work can refill from GFP_KERNEL, napi only from ATOMIC. And if GFP_ATOMIC failed, aggressively retrying might not be a great idea. Not saying refill work is a great hack, but that is the reason for it. -- MST
