On Thu, Dec 18, 2025 at 07:37:43PM +0100, Geert Uytterhoeven wrote:
> Hi Stafford,
>
> On Wed, 17 Dec 2025 at 09:23, Stafford Horne <[email protected]> wrote:
> > Split out the common memory, CPU and PIC definitions of the simple SMP
> > system to a DTSI file which we will later use for our De0 Nano multicore
> > board device tree. We also take this opportunity to swich underscores
> > to dashes as that seems to be the more common convention for DTS files.
> >
> > Signed-off-by: Stafford Horne <[email protected]>
>
> Thanks for your patch!
Thanks for the review. Sorry for the delay my home server (internet) went down
when I was out of the country and I didn't fix until I go back.
> > --- /dev/null
> > +++ b/arch/openrisc/boot/dts/simple-smp.dts
> > @@ -0,0 +1,25 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +
> > +/dts-v1/;
> > +
> > +#include "simple-smp.dtsi"
> > +
> > +/ {
> > + model = "Simple SMP Board";
> > +};
> > +
> > +&cpu0 {
> > + clock-frequency = <20000000>;
> > +};
> > +
> > +&cpu1 {
> > + clock-frequency = <20000000>;
> > +};
> > +
> > +&serial0 {
> > + clock-frequency = <20000000>;
> > +};
> > +
> > +&enet0 {
>
> Alphabetical sort order?
Sure, I'll fix, I didn't know all of the conventions, thanks for pointing out.
> > + status = "okay";
> > +};
> > diff --git a/arch/openrisc/boot/dts/simple_smp.dts
> > b/arch/openrisc/boot/dts/simple-smp.dtsi
> > similarity index 90%
> > rename from arch/openrisc/boot/dts/simple_smp.dts
> > rename to arch/openrisc/boot/dts/simple-smp.dtsi
> > index 71af0e117bfe..2013fd3e7a18 100644
> > --- a/arch/openrisc/boot/dts/simple_smp.dts
> > +++ b/arch/openrisc/boot/dts/simple-smp.dtsi
> > @@ -1,4 +1,3 @@
> > -/dts-v1/;
> > / {
> > compatible = "opencores,or1ksim";
> > #address-cells = <1>;
> > @@ -22,15 +21,13 @@ memory@0 {
> > cpus {
> > #address-cells = <1>;
> > #size-cells = <0>;
>
> Missing blank line.
OK.
> > - cpu@0 {
> > + cpu0: cpu@0 {
> > compatible = "opencores,or1200-rtlsvn481";
> > reg = <0>;
> > - clock-frequency = <20000000>;
> > };
>
> Likewise.
OK.
> > - cpu@1 {
> > + cpu1: cpu@1 {
> > compatible = "opencores,or1200-rtlsvn481";
> > reg = <1>;
> > - clock-frequency = <20000000>;
> > };
> > };
> >
Thanks,
-Stafford
