This commit improves the error handling in passive TFO test to check the
return value from sendto(), and  to fail if read() failed.

Signed-off-by: Yohei Kojima <[email protected]>
---
 tools/testing/selftests/net/tfo.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/net/tfo.c 
b/tools/testing/selftests/net/tfo.c
index 8d82140f0f76..4572eb9b8968 100644
--- a/tools/testing/selftests/net/tfo.c
+++ b/tools/testing/selftests/net/tfo.c
@@ -82,7 +82,8 @@ static void run_server(void)
                error(1, errno, "getsockopt(SO_INCOMING_NAPI_ID)");
 
        if (read(connfd, buf, 64) < 0)
-               perror("read()");
+               error(1, errno, "read()");
+
        fprintf(outfile, "%d\n", opt);
 
        fclose(outfile);
@@ -92,14 +93,17 @@ static void run_server(void)
 
 static void run_client(void)
 {
-       int fd;
+       int fd, ret;
        char *msg = "Hello, world!";
 
        fd = socket(AF_INET6, SOCK_STREAM, 0);
        if (fd == -1)
                error(1, errno, "socket()");
 
-       sendto(fd, msg, strlen(msg), MSG_FASTOPEN, (struct sockaddr 
*)&cfg_addr, sizeof(cfg_addr));
+       ret = sendto(fd, msg, strlen(msg), MSG_FASTOPEN,
+                    (struct sockaddr *)&cfg_addr, sizeof(cfg_addr));
+       if (ret < 0)
+               error(1, errno, "sendto()");
 
        close(fd);
 }
-- 
2.52.0


Reply via email to