Hi Aleksei, Aleksei Oladko <[email protected]> writes:
> The pmtu.sh kselftest configures OVS using ovs-dpctl.py and falls back > to ovs-vsctl only when ovs-dpctl.py fails. However, ovs-dpctl.py exits > with a success status when the installed pyroute2 package version is > lower than 0.6, even though the OVS datapath is not configured. > > As a result, pmtu.sh assumes that the setup was successful and > continues running the test, which later fails due to the missing > OVS configuration. > > Fix the exit code handling in ovs-dpctl.py so that pmtu.sh can detect > that the setup did not complete successfully and fall back to > ovs-vsctl. > > Signed-off-by: Aleksei Oladko <[email protected]> > --- You should also include the fixes line when you post another version: 92e37f20f20a ("selftests: openvswitch: Add version check for pyroute2") > tools/testing/selftests/net/openvswitch/ovs-dpctl.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py > b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py > index b521e0dea506..848f61fdcee0 100644 > --- a/tools/testing/selftests/net/openvswitch/ovs-dpctl.py > +++ b/tools/testing/selftests/net/openvswitch/ovs-dpctl.py > @@ -2583,7 +2583,7 @@ def main(argv): > prverscheck = pyroute2.__version__.split(".") > if int(prverscheck[0]) == 0 and int(prverscheck[1]) < 6: > print("Need to upgrade the python pyroute2 package to >= 0.6.") > - sys.exit(0) > + sys.exit(1) > > parser = argparse.ArgumentParser() > parser.add_argument(
