Hello Andre, On Sat, Jan 24, 2026 at 06:51:42PM +0000, Andre Carvalho wrote: > This patch moves netconsole selftests from drivers/net to its own target > in drivers/net/netconsole. > > This change helps saving some resources from CI since tests in > drivers/net automatically run against real hardware which are not used > by netconsole tests as they rely solely on netdevsim. > > lib_netcons.sh is kept under drivers/net/lib since it is also used by > bonding selftests. Finally, drivers/net config remains unchanged as > netpoll_basic.py requires netconsole (and does leverage real HW testing). > > Signed-off-by: Andre Carvalho <[email protected]>
Thanks for the patch. Looking at NIPA, it seems none of the netconsole test run? https://netdev.bots.linux.dev/contest.html?pw-n=0&branch=net-next-2026-01-25--06-00 > diff --git a/MAINTAINERS b/MAINTAINERS > index 92768bceb929..d92927ce87cc 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -18016,7 +18016,7 @@ S: Maintained > F: Documentation/networking/netconsole.rst > F: drivers/net/netconsole.c > F: tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh > -F: tools/testing/selftests/drivers/net/netcons\* > +F: tools/testing/selftests/drivers/net/netconsole/* I don't think you need * here. The following might be enough. F: tools/testing/selftests/drivers/net/netconsole/ > --- a/tools/testing/selftests/drivers/net/Makefile > +++ b/tools/testing/selftests/drivers/net/Makefile > @@ -15,13 +15,6 @@ TEST_PROGS := \ > hds.py \ > napi_id.py \ > napi_threaded.py \ > - netcons_basic.sh \ > - netcons_cmdline.sh \ > - netcons_fragmented_msg.sh \ > - netcons_overflow.sh \ > - netcons_resume.sh \ > - netcons_sysdata.sh \ > - netcons_torture.sh \ > netpoll_basic.py \ That is right, I don't think we want to move netpoll_basic.py, which is uses netconsole to test netpoll, and we want to run it against real hardware. Thanks --breno
