On Wed, Jan 28, 2026 at 11:18:35AM +0000, Brendan Jackman wrote:
> On Wed Jan 28, 2026 at 9:05 AM UTC, Thomas Weißschuh wrote:
> > When runner.sh is *not* executed via run_kselftest.sh,
>
> Hm, what's the usecase for that? runner.sh is a "library", right? So in
> my mind there's basically an undocumented contract that you need to set
> this variable before you call the relevant functions.
This happens when using 'make run_tests' in a selftest directory.
There the failure currently is also not reported to the caller of make.
Maybe we should make the failures file also work there.
I am not sure what the expected semantics actually are.
In any case, a larger fix should wait for the next cycle,
until then I'd like to get rid of the warning.
> The fix below opens the door to bugs where we fail to report test
> failures which would be... a shame!
>
> > the variable
> > $kselftest_failures_file does not exist. This triggers a harmless but
> > annyoing warning from runner.sh if a test fails:
> >
> > tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or
> > directory
> >
> > Silence the spurious warning.
> >
> > Fixes: d9e6269e3303 ("selftests/run_kselftest.sh: exit with error if tests
> > fail")
> > Signed-off-by: Thomas Weißschuh <[email protected]>
>
> Having said that, it's not a big deal, the risk of those bugs is not
> that high and we'd probably notice them before too long. Assuming you
> have a usecase where just setting the variable to /dev/null yourself is
> a pain, this LGTM.
Passing /dev/null explicitly would also work.
I don't have a strong preference.
> Reviewed-By: Brendan Jackman <[email protected]>
Thanks
Thomas
