On 2/3/26 9:29 AM, Xuan Zhuo wrote:
>> +/*
>> + * Accessors for device-writable fields in virtio rings.
>> + * These fields are concurrently written by the device and read by the
>> driver.
>> + * Use READ_ONCE() to prevent compiler optimizations, document the
>> + * intentional data race and prevent KCSAN warnings.
>> + */
>> +static inline u16 vring_read_split_used_idx(const struct vring_virtqueue
>> *vq)
> "inline" is not recommended in *.c files.
>
> Ohters LGTM.
>
> Thanks.
Is it?
johannes@neo:~/src/linux (master)$ git grep -E "\bstatic inline\b"
{arch,drivers,fs,mm}/**.c | wc -l
18295
That's new to me, sorry. But if there's consensus I can re-send the
patch without inline.
