On Mon, Feb 09, 2026 at 01:14:07PM +0800, Chen Ni wrote:
> Add error checking for regmap_attach_dev() call in
> imx_rproc_mmio_detect_mode() function to ensure proper error
> propagation.
>
> Return the value of regmap_attach_dev() if it fails to prevent
> proceeding with an incomplete regmap setup.
>
> Suggested-by: Peng Fan <[email protected]>
> Signed-off-by: Chen Ni <[email protected]>
> ---
> Changes in v2:
> - Use dev_err() + return ret instead of dev_err_probe()
why?
Frank
> ---
> drivers/remoteproc/imx_rproc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index f5f916d67905..75baf905988b 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -1007,7 +1007,11 @@ static int imx_rproc_mmio_detect_mode(struct rproc
> *rproc)
> }
>
> priv->regmap = regmap;
> - regmap_attach_dev(dev, regmap, &config);
> + ret = regmap_attach_dev(dev, regmap, &config);
> + if (ret) {
> + dev_err(dev, "regmap attach failed\n");
> + return ret;
> + }
>
> if (priv->gpr) {
> ret = regmap_read(priv->gpr, dcfg->gpr_reg, &val);
> --
> 2.25.1
>
