On Tue, Feb 10, 2026 at 10:46 PM Erikas Bitovtas <[email protected]> wrote:
>
> Add support for Capella's CM36686 and CM36672P sensors. Capella
> CM36686 is an ambient light and proximity sensor that is fully
> compatible with VCNL4040 and can be used as is. For CM36672P, which is
> a proximity-only sensor, also remove the IIO_LIGHT channel.
A couple of nit-picks, otherwise LGTM (much better than the first
version!), thanks.
...
> { "vcnl4020", VCNL4010 },
> { "vcnl4040", VCNL4040 },
> { "vcnl4200", VCNL4200 },
> + { "cm36672p", CM36672P },
> + { "cm36686", VCNL4040 },
Keep it ordered by device name (string literal).
...
> +static const struct iio_chan_spec cm36672p_channels[] = {
> + {
> + .type = IIO_PROXIMITY,
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) |
> + BIT(IIO_CHAN_INFO_INT_TIME) |
> + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO) |
> + BIT(IIO_CHAN_INFO_CALIBBIAS),
> + .info_mask_separate_available = BIT(IIO_CHAN_INFO_INT_TIME) |
> + BIT(IIO_CHAN_INFO_OVERSAMPLING_RATIO) |
> + BIT(IIO_CHAN_INFO_CALIBBIAS),
> + .ext_info = vcnl4000_ext_info,
> + .event_spec = vcnl4040_event_spec,
> + .num_event_specs = ARRAY_SIZE(vcnl4040_event_spec),
> + }
Keep trailing comma when it's not a terminator entry.
> +};
--
With Best Regards,
Andy Shevchenko
