On Tuesday 05 February 2008 17:24:57 Andrew Morton wrote: > On Tue, 5 Feb 2008 17:08:37 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > > On Tuesday 05 February 2008 14:53:18 Andrew Morton wrote: > > > That risks killing previously-working setups. WARN_ON is sufficient. > > > > I disagree. WARN_ON is useful for developers, but they can handle > > BUG_ON, too. > > For developers, BUG_ON has zero benefit relative to WARN_ON. > > For non-developers, BUG_ON has large disadvantages relative to WARN_ON. > > It's a no-brainer.
For non-developers, WARN_ON is a noop. For developers, WARN_ON is often a noop. BUG_ON() will make us fix it in return for short-term pain. WARN_ON() wont, in return for less pain. It's mildly better than nothing, but not worth the patch. Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
