Hi, On Sun, 28 Jan 2001, Manfred Spraul wrote: > And one more point for the Janitor's list: > Get rid of superflous irqsave()/irqrestore()'s - in 90% of the cases > either spin_lock_irq() or spin_lock() is sufficient. That's both faster > and better readable. > > spin_lock_irq(): you know that the function is called with enabled > interrupts. > spin_lock(): can be used in hardware interrupt handlers when only one > hardware interrupt uses that spinlocks (most hardware drivers), or when > all hardware interrupt handler set the SA_INTERRUPT flag (e.g. rtc and > timer interrupt) This is not a bug and only helps to make drivers nonportable. Please, don't do this. bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/
- Re: [ANNOUNCE] Kernel Janitor's TODO list Rusty Russell
- Re: [ANNOUNCE] Kernel Janitor's TODO lis... Daniel Phillips
- Re: [ANNOUNCE] Kernel Janitor's TODO... Daniel Phillips
- [RFC] New Improved Stronger Whiter Timer... Daniel Phillips
- Re: [RFC] New Improved Stronger Whit... Daniel Phillips
- Re: [ANNOUNCE] Kernel Janitor's TODO list Manfred Spraul
- Re: [ANNOUNCE] Kernel Janitor's TODO list Arnaldo Carvalho de Melo
- Re: [ANNOUNCE] Kernel Janitor's TODO lis... Manfred Spraul
- Re: [ANNOUNCE] Kernel Janitor's TODO... David Woodhouse
- Re: [ANNOUNCE] Kernel Janitor's ... Manfred Spraul
- Re: [ANNOUNCE] Kernel Janit... Roman Zippel
- Re: [ANNOUNCE] Kernel J... Timur Tabi
- Re: [ANNOUNCE] Kernel J... John Levon
- Re: [ANNOUNCE] Kernel J... David D.W. Downey
- Re: [ANNOUNCE] Kernel J... davej
- Re: [ANNOUNCE] Kernel J... Timur Tabi
- Re: [ANNOUNCE] Kernel J... Rasmus Andersen
- Re: [ANNOUNCE] Kernel J... Peter Samuelson
- Re: [ANNOUNCE] Kernel J... Ingo Oeser
- Re: [ANNOUNCE] Kernel J... David Woodhouse
- Re: [ANNOUNCE] Kernel J... Timur Tabi