On Tue, Mar 10, 2026 at 02:08:40PM +0100, Konrad Dybcio wrote: > On 3/8/26 4:52 PM, Cristian Cozzolino via B4 Relay wrote: > > From: Cristian Cozzolino <[email protected]> > > > > This device uses a Goodix GT5688 touch controller, connected to i2c_3. > > Add it to the device tree. > > > > Signed-off-by: Cristian Cozzolino <[email protected]> > > --- > > .../arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts | 32 > > ++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > > b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > > index 7b2849405462..709ea6fc9fbb 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > > +++ b/arch/arm64/boot/dts/qcom/msm8953-flipkart-rimob.dts > > @@ -94,6 +94,31 @@ &hsusb_phy { > > status = "okay"; > > }; > > > > +&i2c_3 { > > + status = "okay"; > > + > > + touchscreen@5d { > > + compatible = "goodix,gt5688"; > > + reg = <0x5d>; > > + > > + interrupts-extended = <&tlmm 65 IRQ_TYPE_LEVEL_LOW>; > > interrupts *and* irq-gpios sounds wrong.. and I think the driver doesn't > even consume the former. Trying to read through some of that, I think
I think you need both, take a look, there are enough users of ts->gpiod_int. > it's on purpose since the IRQ GPIO is repurposed for setting the I2C addr > (which nota bene doesn't match between the comment in that driver and this > submission - perhaps that's just a SKU difference) during the reset > sequence > > i.e., does the touch work any different if you drop the above? > does /proc/interrupts differ? > > Konrad -- With best wishes Dmitry
