On Thu, Mar 12, 2026 at 01:53:13PM +0200, Erikas Bitovtas wrote: > Add supply, I2C and cathode voltage regulators to the sensor and enable > them. This keeps the sensor powered on even after its only supply shared > by another device shuts down.
> This bug was reported outside of LKML, so no Closes: tag can be > attached. This paragraph should not be part of the commit message. There is a comment/changelog block for that. ... > #include <linux/bitfield.h> > -#include <linux/module.h> > -#include <linux/i2c.h> > -#include <linux/err.h> > #include <linux/delay.h> > -#include <linux/pm_runtime.h> > +#include <linux/err.h> > +#include <linux/i2c.h> > #include <linux/interrupt.h> > +#include <linux/module.h> > +#include <linux/pm_runtime.h> > +#include <linux/regulator/consumer.h> > #include <linux/units.h> Sorting headers should be a separate prerequisite change. ... > + ret = devm_regulator_bulk_get_enable(&client->dev, > + ARRAY_SIZE(regulator_names), > + regulator_names); > + if (ret < 0) > + return ret; > mutex_init(&data->vcnl4000_lock); I would rather expect another prerequisite patch that moves to devm_mutex_init(). -- With Best Regards, Andy Shevchenko
