Mauro Carvalho Chehab <[email protected]> writes: > Sorry for respamming this one too quick. It ends that v1 had some > bugs causing it to fail on several cases. I opted to add extra > patches in the end. This way, it better integrates with kdoc_re. > As part of it, now c_lex will output file name when reporting > errors. With that regards, only more serious errors will raise > an exception. They are meant to indicate problems at kernel-doc > itself. Parsing errors are now using the same warning approach > as kdoc_parser. > > I also added a filter at Ctokenizer __str__() logic for the > string convertion to drop some weirdness whitespaces and uneeded > ";" characters at the output. > > Finally, v2 address the undefined behavior about private: comment > propagation. > > This patch series change how kdoc parser handles macro replacements.
So I have at least glanced at the whole series now; other than the few things I pointed out, I don't find a whole lot to complain about. I do worry about adding another 2000 lines to kernel-doc, even if more than half of them are tests. But hopefully it leads to a better and more maintainable system. We're starting to get late enough in the cycle that I'm a bit leery of applying this work for 7.1. What was your thinking on timing? Thanks, jon
