On 3/5/26 5:55 PM, Siddharth Nayyar wrote: > This patch series implements a mechanism for scalable exported symbol > flags using a separate section called __kflagstab. The series introduces > __kflagstab support, removes *_gpl sections in favor of a GPL flag, > simplifies symbol resolution during module loading.
I noticed that the series has a bisecting issue. The module loader doesn't see any GPL-only exports after patch #4. I think you'll need to squash patches #4 and #5 to fix this. Alternatively, the patches could be swapped, with the caveat that GPL-only symbols would lose their GPL property for one commit. Nit: Please use simply the "module" prefix in commit subjects: #1: module: define ksym_flags enumeration to represent kernel symbol flags #2: module: add kflagstab section to vmlinux and modules #4: module: use kflagstab instead of *_gpl sections #6: module: deprecate usage of *_gpl sections #7: module: remove *_gpl sections from vmlinux and modules The changes look otherwise ok to me. With the above fixed, feel free to add: Reviewed-by: Petr Pavlu <[email protected]> -- Thanks, Petr
