Hi Stanislav, Thanks for the review.
On Mon, Mar 30, 2026 at 02:13:53PM -0700, Stanislav Kinsburskii wrote: > Minor nit: just "end" or even "tmp" would be sufficient, since it's only > used for the overflow checks. "new_region_end" is a bit verbose and it's > not really "new" per se. I will rename it to “region_end" in v3. > This is a PFN, so the check should be against MAX_PHYSMEM_BITS - > PAGE_SHIFT, right? HVPFN_DOWN() is defined as (x) >> HV_HYP_PAGE_SHIFT, so HVPFN_DOWN(1ULL << MAX_PHYSMEM_BITS) already expands to 1ULL << (MAX_PHYSMEM_BITS - HV_HYP_PAGE_SHIFT). Thanks, Junrui Luo
