On Tue, Apr 7, 2026 at 6:55 AM Jakub Kicinski <[email protected]> wrote: > > On Fri, 3 Apr 2026 15:00:50 +0000 Ujjal Roy wrote: > > --- a/tools/testing/selftests/net/forwarding/.gitignore > > +++ b/tools/testing/selftests/net/forwarding/.gitignore > > @@ -1,3 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > forwarding.config > > ipmr > > +mc_encode > > +mc_decode > > please keep this file sorted
I will keep all the codes under a single file and keep them sorted. > > > diff --git a/tools/testing/selftests/net/forwarding/Makefile > > b/tools/testing/selftests/net/forwarding/Makefile > > index bbaf4d937dd8..a26da846632d 100644 > > --- a/tools/testing/selftests/net/forwarding/Makefile > > +++ b/tools/testing/selftests/net/forwarding/Makefile > > @@ -1,5 +1,15 @@ > > # SPDX-License-Identifier: GPL-2.0+ OR MIT > > > > +top_srcdir = ../../../../.. > > + > > +CFLAGS += -Wall -Wl,--no-as-needed -O2 -g -I$(top_srcdir)/usr/include > > $(KHDR_INCLUDES) > > +CFLAGS += -I$(top_srcdir)/tools/include > > Could you please keep the format more aligned with the ksft > net/Makefile? Also is the -I$(top_srcdir)/tools/include > still necessary? KHDR_INCLUDES don't include $src/usr/include ?? > > > +TEST_GEN_FILES := \ > > + mc_encode \ > > + mc_decode \ > > +# end of TEST_GEN_FILES > > Also needs to be sorted > -- > pw-bot: cr I need bitops.h for fls() API, so I can see KHDR_INCLUDES is not needed but tools/include is needed. I don't see lib.mk is including the tools/include. @Nikolay Aleksandrov Please review the updated test cases in this patch.
