On Mon, Apr 06, 2026 at 04:31:50PM +0100, Simon Horman wrote: > On Fri, Apr 03, 2026 at 05:19:12PM +0300, Ioana Ciornei wrote: > > The piece of code which processes the command line arguments and > > populates NETIFS based on them is really unobvious. Rewrite it so that > > the intention is clear and the code is easy to follow. > > > > Suggested-by: Petr Machata <[email protected]> > > Signed-off-by: Ioana Ciornei <[email protected]> > > --- > > tools/testing/selftests/net/forwarding/lib.sh | 22 +++++++++---------- > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > diff --git a/tools/testing/selftests/net/forwarding/lib.sh > > b/tools/testing/selftests/net/forwarding/lib.sh > > index d8cc4c64148d..922cdaf2ceb9 100644 > > --- a/tools/testing/selftests/net/forwarding/lib.sh > > +++ b/tools/testing/selftests/net/forwarding/lib.sh > > @@ -466,18 +466,18 @@ if [ "${DRIVER_TEST_CONFORMANT}" = "yes" ]; then > > NETIFS[p2]="$remote_netif" > > TARGETS[$remote_netif]="$REMOTE_TYPE:$REMOTE_ARGS" > > else > > - count=0 > > AI generated review on Sashiko.dev suggests that initialising count should > be retained to ensure correct behaviour in the (unlikely) case that count > is already set (to a non-zero value) in the environment. > > And this seems like a good idea to me.
Ok. Will add this in v2.
