This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- arm64: dts: qcom: milos: Add IPA node Add the description of the IPA block in the Milos SoC. > diff --git a/arch/arm64/boot/dts/qcom/milos.dtsi > b/arch/arm64/boot/dts/qcom/milos.dtsi > index e1a51d43943f..a244e136a877 100644 > --- a/arch/arm64/boot/dts/qcom/milos.dtsi > +++ b/arch/arm64/boot/dts/qcom/milos.dtsi > @@ -1281,6 +1281,50 @@ adreno_smmu: iommu@3da0000 { > dma-coherent; > }; > > + ipa: ipa@3f40000 { > + compatible = "qcom,milos-ipa"; > + > + reg = <0x0 0x03f40000 0x0 0x10000>, > + <0x0 0x03f50000 0x0 0x5000>, > + <0x0 0x03e04000 0x0 0xfc000>; > + reg-names = "ipa-reg", > + "ipa-shared", > + "gsi"; > + > + interrupts-extended = <&intc GIC_SPI 654 > IRQ_TYPE_EDGE_RISING 0>, > + <&intc GIC_SPI 432 > IRQ_TYPE_LEVEL_HIGH 0>, > + <&smp2p_ipa_in 0 > IRQ_TYPE_EDGE_RISING>, > + <&smp2p_ipa_in 1 > IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "ipa", > + "gsi", > + "ipa-clock-query", > + "ipa-setup-ready"; > + > + clocks = <&rpmhcc RPMH_IPA_CLK>; > + clock-names = "core"; > + > + interconnects = <&aggre2_noc MASTER_IPA > QCOM_ICC_TAG_ALWAYS > + &mc_virt SLAVE_EBI1 > QCOM_ICC_TAG_ALWAYS>, > + <&gem_noc MASTER_APPSS_PROC > QCOM_ICC_TAG_ACTIVE_ONLY > + &cnoc_main SLAVE_IPA_CFG > QCOM_ICC_TAG_ACTIVE_ONLY>; > + interconnect-names = "memory", > + "config"; > + > + iommus = <&apps_smmu 0x4a0 0x0>, > + <&apps_smmu 0x4a2 0x0>; > + > + qcom,qmp = <&aoss_qmp>; > + > + qcom,smem-states = <&smp2p_ipa_out 0>, > + <&smp2p_ipa_out 1>; > + qcom,smem-state-names = "ipa-clock-enabled-valid", > + "ipa-clock-enabled"; > + > + sram = <&ipa_modem_tables>; > ^^^^^^^^^^^^^^^^^^ Is the ipa_modem_tables label defined anywhere? The Device Tree Compiler will fail with "Reference to non-existent node or label 'ipa_modem_tables'" if this label doesn't exist. The sram property is optional according to the qcom,ipa.yaml binding, and other similar Qualcomm SoCs like SM8350, SM8550, and SM8650 don't include this property in their IPA nodes. Should this line be removed, or does the ipa_modem_tables node need to be added to the reserved-memory section? > + > + status = "disabled"; > + }; > + [ ... ]
