Fix four pre-existing bugs in mana_probe()/mana_remove() error handling that can cause warnings on uninitialized work structs, masked errors, and resource leaks when early probe steps fail.
Patches 1-2 move work struct initialization (link_change_work and gf_stats_work) to before any error path that could trigger mana_remove(), preventing WARN_ON in __flush_work() or debug object warnings when sync cancellation runs on uninitialized work structs. Patch 3 prevents add_adev() from overwriting a port probe error, which could leave the driver in a broken state with NULL ports while reporting success. Patch 4 changes 'goto out' to 'break' in mana_remove()'s port loop so that mana_destroy_eq() is always reached, preventing EQ leaks when a NULL port is encountered. --- Changes in v2: * Apply the patch in net instead of net-next. --- Erni Sri Satya Vennela (4): net: mana: Init link_change_work before potential error paths in probe net: mana: Init gf_stats_work before potential error paths in probe net: mana: Don't overwrite port probe error with add_adev result net: mana: Fix EQ leak in mana_remove on NULL port drivers/net/ethernet/microsoft/mana/mana_en.c | 28 +++++++++---------- 1 file changed, 14 insertions(+), 14 deletions(-) -- 2.34.1
