Hi Donet, On Tue, Apr 14, 2026 at 03:11:44PM +0530, Donet Tom wrote: > Hi Mike > > On 4/6/26 7:46 PM, Mike Rapoport wrote: > > From: "Mike Rapoport (Microsoft)" <[email protected]> > > > > Convert ksm_tests to use kselftest framework for reporting and tracking > > successful and failing runs. > > > > Signed-off-by: Mike Rapoport (Microsoft) <[email protected]> > > --- > > tools/testing/selftests/mm/ksm_tests.c | 180 +++++++++++-------------- > > 1 file changed, 81 insertions(+), 99 deletions(-) > > > > > > I think we missed one change > > diff --git a/tools/testing/selftests/mm/ksm_tests.c > b/tools/testing/selftests/mm/ksm_tests.c > index 752a2c0d06ab..5219ee54577d 100644 > --- a/tools/testing/selftests/mm/ksm_tests.c > +++ b/tools/testing/selftests/mm/ksm_tests.c > @@ -104,7 +104,7 @@ static void ksm_print_procfs(void) > > if (!f) { > fprintf(stderr, "f %s\n", file_name); > - perror("fopen"); > + ksft_perror("fopen"); > return; > }
ksm_print_procfs() only called with debug enabled, so I decided to keep it, > > Otherwise it looks good to me > > Reviewed by: Donet Tom <[email protected]> > > -Donet -- Sincerely yours, Mike.
