On Mon, Apr 13, 2026 at 09:18:13PM +0200, David Hildenbrand (Arm) wrote:
> On 4/7/26 05:55, Miaohe Lin wrote:
> > On 2026/4/4 6:31, Lisa Wang wrote:
> >> [...snip...]
> >>>
> >>> Will it be better to add a pr_info here to provide some information for
> >>> users?
> >>>
> >>> Thanks.
> >>> .
> >> I think we don't need to add pr_info here; truncate_error_folio() always
> >> leads to action_result, which already logs the recovery status.
> >
> > No strong opinion but I want to make code style more consistent with sth.
> > like below:
> >
>
> Yeah, would be cleaner.
>
> > if (err == MF_DELAYED)
> > pr_info xxx
> > else if (err != 0)
> > pr_info("%#lx: Failed to punch page: %d\n", pfn, err);
> > else if (!filemap_release_folio(folio, GFP_NOIO))
> > pr_info("%#lx: failed to release buffers\n", pfn);
>
> Maybe we can even make the failed here a "Failed" ;)
Noted. Will update in V4.
Lisa
> --
> Cheers,
>
> David
