On 4/22/26 11:48, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>As per the config name this Display IC features a DSI command-mode interface (or the command to switch to video mode is not known/documented) and does not use any of the video-mode helper utilities, hence should not select VIDEOMODE_HELPERS. In addition it uses devm_gpiod_get() and related functions from GPIOLIB. Fixes: 88148c30ef26 ("drm/panel: Add Samsung S6E3FC2X01 DDIC with AMS641RW panel") Signed-off-by: David Heidelberg <[email protected]> --- drivers/gpu/drm/panel/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig index 2fd3222ba2e3b..a81ea7755c03f 100644 --- a/drivers/gpu/drm/panel/Kconfig +++ b/drivers/gpu/drm/panel/Kconfig @@ -825,20 +825,19 @@ config DRM_PANEL_SAMSUNG_S6D7AA0 tristate "Samsung S6D7AA0 MIPI-DSI video mode panel controller" depends on OF depends on BACKLIGHT_CLASS_DEVICE select DRM_MIPI_DSI select VIDEOMODE_HELPERSconfig DRM_PANEL_SAMSUNG_S6E3FC2X01tristate "Samsung S6E3FC2X01 DSI panel controller" - depends on OF + depends on OF && GPIOLIB
Why OF && GPIOLIB and not on separate depends ?
depends on DRM_MIPI_DSI depends on BACKLIGHT_CLASS_DEVICE - select VIDEOMODE_HELPERS help Say Y or M here if you want to enable support for the Samsung S6E3FC2 DDIC and connected MIPI DSI panel. Currently supported panels:Samsung AMS641RW (found in the OnePlus 6T smartphone) config DRM_PANEL_SAMSUNG_S6E3HA2
