On 29 Apr 2026, at 17:16, Ilya Maximets wrote:
> Two patches - the fix for the actual bug and the selftest that reproduces it.
>
> I missed the self-deadlock in the original patch that introduced the issue,
> because testing required code modification in the ovs-vswitchd to force it to
> use legacy tunnel ports. I thought I made the change correctly, but
> apparently
> something went wrong and the tests were run with the standard LWT infra
> instead.
> The selftest added in this patch set will at least prevent this kind of
> mistakes
> in the future.
>
> I mentioned, however, that these tunnel vports are legacy and not actually
> used
> by ovs-vswitchd. RTM_NEWLINK + COLLECT_METADATA is used in conjunction with
> the
> standard OVS_VPORT_TYPE_NETDEV instead since 2017. The code to use the legacy
> tunnels still exists in ovs-vswitchd however, but only as a fallback for older
> kernels and we're planning to remove it in the next release. I'll be sending
> an
> RFC to remove support for these legacy tunnel types from the kernel, as they
> serve no real purpose today and only increase the uAPI surface for CVEs, but
> we need to fix the known bugs for stable versions.
Thanks, Ilya, for working on this patch! It looks good to me, assuming you
remove the unused socket library in v2.
For the series:
Acked-by: Eelco Chaudron <[email protected]>
