Hi Sarthak,
On Tue, May 05, 2026 at 05:18:38PM +0530, Sarthak Sharma wrote:
> On 4/29/26 2:12 AM, Mike Rapoport wrote:
> > @@ -1771,7 +1794,7 @@ int main(int argc, char *argv[])
> > uffd_test_case_ops = test->test_case_ops;
> >
> > if (mem_type->mem_flag & (MEM_HUGETLB_PRIVATE |
> > MEM_HUGETLB)) {
> > - gopts.page_size = default_huge_page_size();
> > + gopts.page_size = hugepage_size;
> > if (gopts.page_size == 0) {
> > uffd_test_skip("huge page size is 0,
> > feature missing?");
>
> A small nit, after this patch, uffd_setup_hugetlb() can return 0 in 2 cases:
>
> a) default_huge_page_size() == 0
> b) hugetlb_free_default_pages() < nr_hugepages
>
> The skip message only covers the first case and would be misleading for
> the second case. Should we differentiate both these using different skip
> messages?
I'm more inclined to have a single "Not enough huge pages" message to keep
the things simple.
> > continue;
>
--
Sincerely yours,
Mike.
