On Mon, May 11, 2026 at 08:10:04PM +0800, Arnab Layek wrote: > The MT8188 SCP requires two reserved memory regions: > 1. Main SCP SRAM memory region (required) > 2. SCP L1TCM memory region (optional, for additional memory) > > Some other MediaTek SoCs only use a single memory region. This patch adds
Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94 > a conditional schema using if/then to allow 1-2 memory regions > specifically for mediatek,mt8188-scp and mediatek,mt8188-scp-dual > compatibles, while keeping the default maxItems: 1 for other > SoCs. Stop explaining what you did. Explain WHY. Why second entry is optional? Why are you changing existing binding? Was it working? Not? Why not? Why yes? > > Each memory region is documented with descriptions to > clarify their purpose, following the pattern used in other bindings. Redundant. We can read the diff. > > Signed-off-by: Arnab Layek <[email protected]> > --- > .../bindings/remoteproc/mtk,scp.yaml | 21 +++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > index bdbb12118da4..df13be2026a6 100644 > --- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml > @@ -205,6 +205,27 @@ allOf: > items: > - const: cfg > - const: l1tcm > + - if: > + properties: > + compatible: > + enum: > + - mediatek,mt8188-scp > + - mediatek,mt8188-scp-dual > + then: > + properties: > + memory-region: > + minItems: 1 > + items: > + - description: Main SCP SRAM memory region > + - description: Optional SCP L1TCM memory region Conflicts top level. > + patternProperties: > + "^scp@[a-f0-9]+$": > + properties: > + memory-region: > + minItems: 1 > + items: > + - description: Main SCP SRAM memory region > + - description: Optional SCP L1TCM memory region > > additionalProperties: false > > -- > 2.45.2 >
