> diff --git a/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c 
> b/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c
> index 1a3233a275c7..3b05ac1d7c77 100644
> --- a/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c
> +++ b/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c
> @@ -197,17 +197,13 @@ static bool
>  fq_flows_is_empty(struct bpf_list_head *head, struct bpf_spin_lock *lock)
>  {
>       struct bpf_list_node *node;
                              ^^^^

The variable 'node' is no longer used after removing the pop/push logic.
Will this trigger an unused-variable compiler warning and break the selftests
build?

>  +    bool empty;
>
>       bpf_spin_lock(lock);
> -     node = bpf_list_pop_front(head);
> -     if (node) {
> -             bpf_list_push_front(head, node);
> -             bpf_spin_unlock(lock);
> -             return false;
> -     }
> +     empty = bpf_list_empty(head);
>       bpf_spin_unlock(lock);
>
> -     return true;
> +     return empty;
>  }


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/26340856238

Reply via email to