On Fri, 2008-02-08 at 23:10 -0400, Konrad Rzeszutek wrote:
> +       ibft_device = kmalloc(len, GFP_KERNEL);
> +       if (!ibft_device)
> +               return -ENOMEM;
> +
> +       memcpy(ibft_device, hdr, len);

This piece looks a bit odd.  you're making ibft_device an exact
duplicate of ibft_addr (which is reserved in bootmem and lives as long
as the kernel does).  I can't seem to find anywhere you actually modify
ibft_device, so why not just use the original ibft_addr here instead of
making a copy?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to