Subject [PATCH net-next] drivers/net/can/usb/kvaser_usb: User strscpy() to copy
device name
^^^^
Use?
On 06/06/2026 at 22:26, [email protected] wrote:
> From: David Laight <[email protected]>
>
> Signed-off-by: David Laight <[email protected]>
> ---
> This is one of a group of patches that remove potentially unbounded
> strcpy() calls.
>
> They are mostly replaced by strscpy() or, when strlen() has just been
> called, with memcpy() (usually including the '\0').
>
> Calls with copy string literals into arrays are left unchanged.
> They are safe and easily detected as such.
>
> The changes were made by getting the compiler to detect the calls and
> then fixing the code by hand.
>
> Note that all the changes are only compile tested.
>
> Some Makefiles were changed to allow files to contain strcpy().
> As well as 'difficult to fix' files, this included 'show' functions
> as they really need to use sysfs_emit() or seq_printf().
>
> All the patches are being sent individually to avoid very long cc lists.
> Apologies for the terse commit messages and likely unexpected tags.
> (There are about 100 patches in total.)
Indeed, this is terse. The commit body is empty (all your comments are
below the --- cutter) and the subject line contains a typo.
I don't see why the fact that you are sending many fixes clears you
from writing a proper commit message. And I would expect at least a
small effort to customize the message: only explain the Makefile stuff
for the patches which are touching a Makefile.
> drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c
> b/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c
> index e09d663e362f..2cd58e825e0e 100644
> --- a/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c
> +++ b/drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c
> @@ -746,7 +746,7 @@ static int kvaser_usb_hydra_map_channel(struct kvaser_usb
> *dev, u16 transid,
> if (!cmd)
> return -ENOMEM;
>
> - strcpy(cmd->map_ch_req.name, name);
> + strscpy(cmd->map_ch_req.name, name);
> cmd->header.cmd_no = CMD_MAP_CHANNEL_REQ;
> kvaser_usb_hydra_set_cmd_dest_he
> (cmd, KVASER_USB_HYDRA_HE_ADDRESS_ROUTER);
Yours sincerely,
Vincent Mailhol
