On 6/21/26 7:27 AM, David Heidelberg wrote:
On 18/06/2026 23:38, Rhodes, David wrote:
On 6/18/26 9:33 AM, David Heidelberg via B4 Relay wrote:
From: David Heidelberg <[email protected]>
Convert CS35L36 Speaker Amplifier.
Changes:
- maintainers email to the generic Cirrus email
- Both the codec and downstream worked just fine without
VP-supply provided. Align with datasheet for similar models.
- add dai-common.yaml to cover for '#sound-dai-cells',
'sound-name-prefix'
Co-developed-by: Rob Herring (Arm) <[email protected]>
Signed-off-by: Rob Herring (Arm) <[email protected]>
Signed-off-by: David Heidelberg <[email protected]>
---
Reviewed-by: David Rhodes <[email protected]>
Thanks for the review. btw. could you please verify against datasheet,
if the
- cirrus,classh-wk-fet-delay is also possible for cs35l36 (l35 has it,
but l36 driver doesn't, thou DT isn't about driver, so checking)
- cirrus,weak-fet-disable and cirrus,classh-weak-fet-thld-millivolt
are also not implemented in any driver, but present in DT.
If hardware is capable and the driver just doesn't have impl. it's fine,
but otherwise I would remove these in v2.
Thank you
David :D
Hardware is capable and the driver does not have implementation.
This would be the register referred to as CS35L36_CLASSH_FET_DRV_CFG.
Thanks,
David
