On Mon, 11 Feb 2008 01:13:09 +0100 (CET) Jan Engelhardt <[EMAIL PROTECTED]> wrote:
> > On Feb 10 2008 15:55, Arjan van de Ven wrote: > >+#ifdef CONFIG_DEVKMEM > > /* > > * This function reads the *virtual* memory as seen by the kernel. > > */ > >@@ -585,6 +588,11 @@ static ssize_t write_kmem(struct file * file, > >const char __user * buf, > > *ppos = p; > > return virtr + wrote; > > } > >+#else > >+#define read_kmem NULL > >+#define write_kmem NULL > >+#define mmap_kmem NULL > >+#endif > > Is the #else case needed? All kmem_fops uses seem #ifdef'ed out > anyway, except kmem_fops itself. In other words, > > +#ifdef CONFIG_DEVKMEM > static const struct file_operations kmem_fops = { > ... > } > +#endif > > and do away with the three defines. No? :) hmm I tried that first, and didn't work but that wasn't on the final version of the patch so let me try again.. -- If you want to reach me at my work email, use [EMAIL PROTECTED] For development, discussion and tips for power savings, visit http://www.lesswatts.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/