On 30/06/2026 09:32, Hongfu Li wrote:
> [...]
>
> diff --git a/tools/testing/selftests/mm/pkey_util.c
> b/tools/testing/selftests/mm/pkey_util.c
> index 255b332f7a08..abf708d6575e 100644
> --- a/tools/testing/selftests/mm/pkey_util.c
> +++ b/tools/testing/selftests/mm/pkey_util.c
>
> [...]
>
> +void abort_hooks(void)
> +{
> + fflush(stdout);
> + fprintf(stderr, "running %s()...\n", __func__);
> + tracing_off();
> +#ifdef SLEEP_ON_ABORT
> + sleep(SLEEP_ON_ABORT);
> +#endif
> +}
Definitely an improvement to move this to pkey_util.c. We still have
multiple functions declared in pkey-helpers.h and defined in
protection_keys.c (which clearly doesn't make sense), but this is a step
in the right direction.
Reviewed-by: Kevin Brodsky <[email protected]>
