On Mon, 6 Jul 2026 22:09:39 +0200, Andy Shevchenko <[email protected]> said: > On Mon, Jul 06, 2026 at 08:32:28AM -0400, Bartosz Golaszewski wrote: >> On Mon, 29 Jun 2026 17:58:16 +0200, Andy Shevchenko >> <[email protected]> said: >> > On Mon, Jun 29, 2026 at 12:52:10PM +0200, Bartosz Golaszewski wrote: > > ... > >> >> +static int gpio_probe_defer_consumer_probe(struct platform_device *pdev) >> >> +{ >> >> + struct device *dev = &pdev->dev; >> >> + struct gpio_probe_defer_pdata *pdata = dev_get_platdata(dev); >> >> + struct gpio_desc *desc; >> > >> >> + pdata->probe_count++; >> > >> > Even in case of error? >> >> We're counting how many times we *enter* probe, so yes, I think it's right. > > Perhaps a (short) comment on top of this line? > > /* Count probes independently on being successful or unsuccessful */ > > -- > With Best Regards, > Andy Shevchenko > > >
I mean: sure, I can, but it already says probe_count, not probe_ok_count. IMO it's overkill but I don't want to bikeshed over a comment. Bart
