This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
Full review at:
https://sashiko.dev/#/patchset/[email protected]?part=3
---
--- Patch [3]: [PATCH net-next 3/6] uapi: tc_act: add tc_frer UAPI header ---
commit 070d4b29514ff2aff8a973818dd8d51372a699d4
Author: Xiaoliang Yang <[email protected]>
uapi: tc_act: add tc_frer UAPI header
This commit defines the netlink attribute layout and enumerations for the
FRER tc action (IEEE 802.1CB). It introduces functional sub-commands,
recovery configurations, and read-only statistics.
> diff --git a/include/uapi/linux/tc_act/tc_frer.h
> b/include/uapi/linux/tc_act/tc_frer.h
> new file mode 100644
> index 0000000000000..241e90827e262
> --- /dev/null
> +++ b/include/uapi/linux/tc_act/tc_frer.h
[ ... ]
> +enum {
> + TCA_FRER_UNSPEC,
> + TCA_FRER_TM, /* struct tcf_t */
> + TCA_FRER_PARMS, /* struct tc_frer */
> + TCA_FRER_PAD,
> + TCA_FRER_FUNC, /* u8: tc_frer_func */
> + TCA_FRER_TAG_TYPE, /* u8: tc_frer_tag_type */
> + TCA_FRER_RCVY_INDIVIDUAL, /* NLA_FLAG */
> + TCA_FRER_RCVY_ALG, /* u8: tc_frer_rcvy_alg */
> + TCA_FRER_RCVY_HISTORY_LEN, /* u8: 1-32 */
[Severity: Medium]
Are these u8 attributes necessary here, or should they be u32? The Netlink
UAPI guidelines recommend avoiding integer types smaller than 32 bits for
attributes. They save no memory due to the 4-byte attribute alignment and
using smaller types unnecessarily restricts future extensibility.
